-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: incremental updates with updatedAfter #71
Open
fracasula
wants to merge
28
commits into
main
Choose a base branch
from
updatedAt
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,239
−935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fracasula
changed the title
feat: updatedAfter support
feat: incremental updates with updatedAfter
Dec 5, 2024
fracasula
requested review from
fxenik,
ktgowtham,
aris1009,
BonapartePC and
achettyiitr
December 5, 2024 17:38
* chore: experimenting with new approach * fix: 2nd yield * fix: unused code * test: new approach * test: non updateables * chore: finishing up
@fxenik , could you review it from CP side? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding support for INCREMENTAL UPDATES with
updatedAfter
+ general cleanup.USAGE SHOWCASE HERE
IMPORTANT DISCLAIMER
Now it is possible to use the SDK and the Poller with any object, not just
*modelv2.WorkspaceConfigs
.This is possible as long as the aforementioned object satisfies a few contracts with generics.
In order to be efficient when handling such big objects, iterators have been used (i.e.
yield
,iter.Seq
,iter.Seq2
).Changelog
updated
, a variable that allows us to understand if we actually got something new from ControlPlane so that we don't waste computation on the application side rebuilding things every time unless needed.GetCustomWorkspaceConfigs
). Now everything is handled byGetWorkspaceConfigs
.diff
package that leverages generics and iterators (i.e.yield
) to efficiently handle the payload.TODOs
Update a few deps once this is merged (see open PRs).
Linear Ticket
< Linear_Link >
Security